Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix input.value undefined #770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix input.value undefined #770

wants to merge 1 commit into from

Conversation

cavasinf
Copy link

@cavasinf cavasinf commented Aug 30, 2024 •
edited
Loading

Fix error when using trim() on an undefined value.

image

I don't know if you guys accept optional chaining for browser compatibility.
eg:

input.value?.trim() ?? ''

So I've ended up using a simple ternary operator.

@nwalters512
Copy link
Contributor

@cavasinf can you share a reproduction for the original issue you found? I'm struggling to see how value could be undefined here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cavasinf @nwalters512